svn commit: r282672 - head/etc/rc.d

[Eitan Adler]

On 11 May 2015 at 12:18, Brooks Davis <brooks at freebsd.org> wrote:
> On Sun, May 10, 2015 at 03:45:48PM -0400, John Baldwin wrote:
>>
>> > On May 8, 2015, at 19:36, Xin LI <delphij at FreeBSD.org> wrote:
>> >
>> > Author: delphij
>> > Date: Fri May  8 23:36:31 2015
>> > New Revision: 282672
>> > URL: https://svnweb.freebsd.org/changeset/base/282672
>> >
>> > Log:
>> >  Always convert uuid to lower case.
>> >
>> >  MFC after:    2 weeks
>> >
>> > Modified:
>> >  head/etc/rc.d/hostid
>> >
>> > Modified: head/etc/rc.d/hostid
>> > ==============================================================================
>> > --- head/etc/rc.d/hostid    Fri May  8 23:29:42 2015    (r282671)
>> > +++ head/etc/rc.d/hostid    Fri May  8 23:36:31 2015    (r282672)
>> > @@ -58,7 +58,7 @@ hostid_set()
>> >
>> > valid_hostid()
>> > {
>> > -    uuid=$1
>> > +    uuid=$(echo $1 | tr '[:upper:]' '[:lower:]')
>>
>> tr is in /usr/bin so this breaks systems with a separate /usr.  Perhaps you could use dd with conv=lcase instead?
>
> Alterntively, a shell function "ltr" exists in rc.subr for this purpose.

Why does the hostid need to be lowercase in the first place?


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams