svn commit: r282728 - head/sys/boot/efi/loader/arch/i386

Ian Lepore ian at FreeBSD.org
Sun May 10 13:30:22 UTC 2015


Author: ian
Date: Sun May 10 13:30:21 2015
New Revision: 282728
URL: https://svnweb.freebsd.org/changeset/base/282728

Log:
  Don't check the return value from self_reloc(), it can't fail and doesn't
  return a value.
  
  Despite what I said in my prior commit, it turns out this one platform
  was checking the return value from the old self-reloc code (which returned
  a hard-coded 0).

Modified:
  head/sys/boot/efi/loader/arch/i386/start.S

Modified: head/sys/boot/efi/loader/arch/i386/start.S
==============================================================================
--- head/sys/boot/efi/loader/arch/i386/start.S	Sun May 10 13:24:26 2015	(r282727)
+++ head/sys/boot/efi/loader/arch/i386/start.S	Sun May 10 13:30:21 2015	(r282728)
@@ -54,8 +54,6 @@ ENTRY(_start)
 	pushl	%ebx		/* dynamic */
 	pushl	%eax		/* ImageBase */
 	call	self_reloc
-	cmpl	$EFI_SUCCESS, %eax
-	jne	1f
 	popl	%ebx		/* remove ImageBase from the stack */
 	popl	%ebx		/* remove dynamic from the stack */
 	call	efi_main


More information about the svn-src-head mailing list