svn commit: r282421 - in head: . etc

[Bryan Drewery]

On 5/4/2015 11:34 AM, Baptiste Daroussin wrote:
> Author: bapt
> Date: Mon May  4 16:34:08 2015
> New Revision: 282421
> URL: https://svnweb.freebsd.org/changeset/base/282421
> 
> Log:
>   Remove now unneeded libmap32.conf

This doesn't explain why; the commit message is useless. "Because
r282420 ..."

> 
> Deleted:
>   head/etc/libmap32.conf
> Modified:
>   head/ObsoleteFiles.inc
>   head/etc/Makefile
> 
> Modified: head/ObsoleteFiles.inc
> ==============================================================================
> --- head/ObsoleteFiles.inc	Mon May  4 16:28:54 2015	(r282420)
> +++ head/ObsoleteFiles.inc	Mon May  4 16:34:08 2015	(r282421)
> @@ -39,6 +39,7 @@
>  # done
>  
>  # 20150504
> +OLD_FILES+=etc/libmap32.conf

This seems dangerous. I think only files no longer useful in any context
should be added here. A user may have their own libmap32.conf that this
would remove. Mergemaster/etcupdate might handle this case fine without
delete-old.

There are several other bugs with libmap32.conf:

 There's no manpage.
 There's no default /usr/local/etc/libmap32.d dir or entry.


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20150504/bf585f45/attachment.sig>