svn commit: r280133 - head/usr.sbin/bhyve

Alexander Motin mav at FreeBSD.org
Tue Mar 17 08:03:02 UTC 2015


On 17.03.2015 02:38, Justin T. Gibbs wrote:
> On Mar 16, 2015, at 3:16 AM, Alexander Motin <mav at FreeBSD.org> wrote:
>>
>> Author: mav
>> Date: Mon Mar 16 09:15:59 2015
>> New Revision: 280133
>> URL: https://svnweb.freebsd.org/changeset/base/280133
>>
>> Log:
>>  Increase S/G list size of 32 to 33 entries.
>>
>>  32 entries are not enough for the worst case of misaligned 128KB request,
>>  that made FreeBSD to chunk large quests in odd pieces.
>>
>>  MFC after:	2 weeks
>>
>> Modified:
>>  head/usr.sbin/bhyve/block_if.h
>>  head/usr.sbin/bhyve/pci_virtio_block.c
>>
>> Modified: head/usr.sbin/bhyve/block_if.h
>> ==============================================================================
>> --- head/usr.sbin/bhyve/block_if.h	Mon Mar 16 01:15:08 2015	(r280132)
>> +++ head/usr.sbin/bhyve/block_if.h	Mon Mar 16 09:15:59 2015	(r280133)
>> @@ -39,7 +39,7 @@
>> #include <sys/uio.h>
>> #include <sys/unistd.h>
>>
>> -#define BLOCKIF_IOV_MAX		32	/* not practical to be IOV_MAX */
>> +#define BLOCKIF_IOV_MAX		33	/* not practical to be IOV_MAX */
> 
> Shouldn’t these be derived from MAXPHYS?

I am not sure. This is user-level, what it know about MAXPHYS? And what
MAXPHYS means for file I/O? It may be more tuned for guest's potential
MAXPHYS rather then host's one.

-- 
Alexander Motin


More information about the svn-src-head mailing list