svn commit: r284602 - head/sys/kern

John Baldwin jhb at FreeBSD.org
Sat Jun 20 13:53:36 UTC 2015


On 6/19/15 2:57 PM, Sean Bruno wrote:
> Author: sbruno
> Date: Fri Jun 19 18:57:36 2015
> New Revision: 284602
> URL: https://svnweb.freebsd.org/changeset/base/284602
> 
> Log:
>   Feedback from commit r284535
>   
>   davide:  imgact_binmisc_clear_entry() needs to use atomic ops to remove
>   the enable bit.

I had asked you to remove the atomics and instead use an exclusive lock
in the enable/disable routines as these are not hotpaths and that is
simpler.  Stacey agreed with that assessment in his review comment.
It looks like you removed the atomics but forgot to switch the shared
locks to exclusive locks.  I would still prefer using exclusive locks
and removing the atomics.

-- 
John Baldwin


More information about the svn-src-head mailing list