svn commit: r284409 - in head/cddl/lib: libzfs libzfs_core

[Andriy Gapon]

On 15/06/2015 21:06, Warner Losh wrote:
> 
>> On Jun 15, 2015, at 8:37 AM, Matthew Ahrens <matt at mahrens.org> wrote:
>> 
>> 
>> 
>> On Mon, Jun 15, 2015 at 7:53 AM, Andriy Gapon <avg at freebsd.org> wrote:
>> 
>> P.S. My personal preference would be to drop that compat code and to 
>> convince ZFS/FreeBSD users to always use boot environments, so that their
>> kernel and userland never fall out of sync :)
>> 
>> Me too :-)
> 
> Sadly, there are a number of upgrade scenarios where this simply isn’t 
> possible.

Curious what are those...
The only scenario I can think of is one where there is not enough space to
hold the previous OS bits and the new ones.  But in such a constrained system
there is probably not much use for ZFS anyway.

> But looking at the file, it appears to be full of stuff to do the 8.x -> 
> 9.x upgrade of ZFS to format 28. Perhaps that can now be removed?

I would expect that every user of ZFS/FreeBSD has moved past that line by now,
but who knows...

> These libraries appear to be versioned, rather than symbol versioned 
> otherwise Baptiste’s commit would have been bad… but  I wonder if maybe a 
> version bump is in order…

I think we should be okay without a version bump, because the symbol is moved
from a library to its dependency.  So, libzfs_core interface is extended and
that should not be a problem for its users.  And libzfs users should not
notice that the symbol migrated from libzfs to libfzs_core because the users
have to link to both libraries (or load both of them).

-- 
Andriy Gapon