svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush usr.sbin/ypserv

[Ed Schouten]

Hi Marcelo,

Thanks for working on this!

2015-07-28 4:32 GMT+02:00 Marcelo Araujo <araujo at freebsd.org>:
> -struct ypalias {
> +const struct ypalias {
>         char *alias, *name;
> -} ypaliases[] = {
> +} static ypaliases[] = {
>         { "passwd", "passwd.byname" },
>         { "master.passwd", "master.passwd.byname" },
>         { "shadow", "shadow.byname" },

I seem to remember that certain compilers (Intel?) are pretty picky
about the ordering of 'static' and 'const'.

const static int i; // Compiler error.

It's also inconsistent with the rest of our codebase, where we
typically put 'static' in front of the type. Could you please change
this to the following?

static const struct ypalias {
   ...
} ypaliases[] = {
   ...
};

Thanks!

-- 
Ed Schouten <ed at nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK/VAT number: 62051717