svn commit: r285803 - head/bin/ls

[Allan Jude]

On 2015-07-24 15:41, Pedro Giffuni wrote:
>
>
> On 07/24/15 14:10, Allan Jude wrote:
>> ...
>
>>
>> The r285734 change didn't explicitly cast some references to uid_t,
>> resulting in a segfault on i386. Clang generated a warning about this
>> immediately while I was debugging when I duplicated the xo_emit
>> command as a printf.
>>
>> Can we teach our clang that xo_emit is printf, and so the same
>> formatting type matching should be checked? That would be very helpful.
>>
>
> Perhaps something like this? (untested)
>
> Pedro.
>
>

Yes, jhb@ pointed me in the same direction, and I have already submitted 
it upstream. It seems they already had it on some things, just not the 
most useful case.

https://github.com/Juniper/libxo/pull/45


-- 
Allan Jude