svn commit: r285803 - head/bin/ls

[Antoine Brodin]

On Wed, Jul 22, 2015 at 9:58 PM, Allan Jude <allanjude at freebsd.org> wrote:
> Author: allanjude (doc committer)
> Date: Wed Jul 22 19:58:21 2015
> New Revision: 285803
> URL: https://svnweb.freebsd.org/changeset/base/285803
>
> Log:
>   Remove an excess space accidently introduced in the output in ls(1) by r285734
>
>   Spotted by:   dim
>   Approved by:  eadler (mentor)
>   Sponsored by: ScaleEngine Inc.
>   Differential Revision:        https://reviews.freebsd.org/D3152
>
> Modified:
>   head/bin/ls/print.c

Hi,

Some recent (less than 5 days old) changes on ls(1) broke it on i386,
and more than 8000 ports are affected by this.

See for instance
http://beefy3.nyi.freebsd.org/data/head-i386-default/p392703_s285807/logs/errors/autoconf-2.69.log

>From the log:
%%%
gmake[3]: Entering directory
'/wrkdirs/usr/ports/devel/autoconf/work/autoconf-2.69/doc'
Segmentation fault (core dumped)
../build-aux/mdate-sh: failed parsing 'ls -L -l -d -n /' output
Updating ./version.texi
%%%
It used to build fine with r285732 and doesn't work anymore at r285807.

Cheers,

Antoine


>
> Modified: head/bin/ls/print.c
> ==============================================================================
> --- head/bin/ls/print.c Wed Jul 22 19:55:32 2015        (r285802)
> +++ head/bin/ls/print.c Wed Jul 22 19:58:21 2015        (r285803)
> @@ -456,7 +456,7 @@ printtime(const char *field, time_t ftim
>         snprintf(fmt, sizeof(fmt), "{d:%s/%%hs} ", field);
>         xo_attr("value", "%ld", (long) ftime);
>         xo_emit(fmt, longstring);
> -       snprintf(fmt, sizeof(fmt), "{en:%s/%%ld} ", field);
> +       snprintf(fmt, sizeof(fmt), "{en:%s/%%ld}", field);
>         xo_emit(fmt, (long) ftime);
>  }
>
>