svn commit: r285552 - head/usr.bin/xargs

[Xin Li]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 07/14/15 15:17, Ian Lepore wrote:
> On Tue, 2015-07-14 at 13:44 -0700, Xin Li wrote:
>> On 07/14/15 13:29, Garrett Cooper wrote:
>>> On Jul 14, 2015, at 12:16, Baptiste Daroussin
>>> <bapt at FreeBSD.org> wrote:
>>> 
>>>> Author: bapt Date: Tue Jul 14 19:16:14 2015 New Revision:
>>>> 285552 URL: https://svnweb.freebsd.org/changeset/base/285552
>>>> 
>>>> Log: Convert atoi(3) to stronum(3) which allows to arguments
>>>> and report proper errors to the users
>>> 
>>> Is strtonum preferred over strtoll, etc?
>> 
>> strtonum(3) is a wrapper of strtoll() and provides more
>> functionality like range checking, so I think the answer would be
>> yes.
>> 
>> Cheers,
>> 
> 
> Except if we convert all our tools that take numbers on the command
> line to use strtonum() then peoples' existing scripts and other
> automation that passes 0xWhatever numbers suddenly stop working.
> strtonum() seems to be about 2/3 of a good idea.

I think the caller has to be calling with 0 or 16 as base to request
that behavior?  If we are converting from atoi, the base number is a
fixed value of 10.

My only concern with strtonum() is that it's English only.

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.6 (FreeBSD)

iQIcBAEBCgAGBQJVpaMOAAoJEJW2GBstM+nsA9kP/29HyJZXJQbP57/hhZLpCln4
dO9ScoZxsdvrKzeMfxI3/u16vl2Ei5nkiYLga8gfkpqcmsAc11duomJHvq0BHe2j
7Srr8m4CYsk6bp32qaIBCl9weKz5jR56EaMBn6FfplCYlx+5noHIulXdKz5tWJqF
IHiHdXUAGCGPLMLVeVatMk02x1VoCwkSvwyZ070COlZMdz0tfKBz5uvren3C/LCq
eI6+9cVXYv5fBChW7CHwtcgtFcILmfaYuzWfOm+i87gj0YfMGa8aq8WjHAkC+JzR
lW+WRk8RONhbfIg0fJ8PkrGeinNgaiu9mUDH6qmpqM2Zfy68trxVuBNKtI8ygSJz
z7BDsP6TsD/+z02cV9C3wuYGx8U117MVBmFT86W1a7II0VXAug0wg/XUTh9xCWaU
w52k/ZfFO0ZE4P+cz/NiFco+MXHpn5Q32lmpWBwv1OAVmaImHTZ3IOkO9LdwsbiX
5Bbj6odEACd64WzgorCdIHt7gcWBFxNjLE/NDUw1CqStqEAzkS8Ny//nG0GC5S9q
IO+1epMAWnHxsGJC3zBjYOQUgMRdPmRi35yAxuUpa2tccBFIuPRAkrP24rtQhOB/
USB1a75Dlmr4YssrFKi5ir0pEVg/7JmO0mfsR94en3riq+d7+dD4m4tgUe/QPGjo
3ReYZc3VrLgn2ORs9nH/
=VzoB
-----END PGP SIGNATURE-----