svn commit: r285404 - head/sys/compat/cloudabi

[Ed Schouten]

Hi Kostik,

> Exactly. I think that for programs that are built around pipelines,
> where a series of processes have stdin/stdout attached, having
> something like SIGPIPE makes sense. So far the focus

It looks like I accidentally truncated the last sentence. Sorry about that.

"So far the focus with CloudABI is on running services, in which
stdin/stdout typically don't play a role."

2015-07-14 13:01 GMT+02:00 Konstantin Belousov <kostikbel at gmail.com>:
> On Tue, Jul 14, 2015 at 12:22:51PM +0200, Ed Schouten wrote:
>> Ah, okay. Now I think I understand what you're hinting at. So your
>> proposal is to let cloudabi_sys_proc_raise() only call into
>> sys_kill(), nothing else. We then reset all signals to their default
>> behavior at some point during process startup.
>>
>> Let me address this by the time I'm sending out the CloudABI sysentvec
>> for review, as that would be the place where I'd need to do that. I'll
>> remove the call to kern_sigaction() in the meantime. Does that sound
>> all right?
>
> Sounds fine.  But, I do not recomment to use sys_kill(), which is
> the FreeBSD syscall implementation.  You should use pksignal(9) or
> similar function directly, IMO.  Minor code duplication to create
> proper ksiginfo is not critical, while you do not need pfind() or
> complications with negative pid values.

That sounds like a good idea. I just sent you a code review:

https://reviews.freebsd.org/D3076

Thanks for your time!

-- 
Ed Schouten <ed at nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK/VAT number: 62051717