svn commit: r285336 - in head/sys: netipsec opencrypto

[Patrick Kelsey]

On Thu, Jul 9, 2015 at 10:45 PM, Warner Losh <imp at bsdimp.com> wrote:

>
> > On Jul 9, 2015, at 8:27 PM, George Neville-Neil <gnn at freebsd.org> wrote:
> >
> >
> >
> > On 9 Jul 2015, at 18:26, Peter Wemm wrote:
> >
> >> On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote:
> >>> Author: gnn
> >>> Date: Thu Jul  9 18:16:35 2015
> >>> New Revision: 285336
> >>> URL: https://svnweb.freebsd.org/changeset/base/285336
> >>>
> >>> Log:
> >>> Add support for AES modes to IPSec.  These modes work both in software
> >>> only mode and with hardware support on systems that have AESNI
> >>> instructions.
> >>>
> >>> Differential Revision:      D2936
> >>> Reviewed by:        jmg, eri, cognet
> >>> Sponsored by:       Rubicon Communications (Netgate)
> >>>
> >>> Modified:
> >>> head/sys/netipsec/xform_ah.c
> >>> head/sys/netipsec/xform_esp.c
> >>
> >>> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp)
> >>>                     case CRYPTO_SHA2_512_HMAC:
> >>>                             alen = esph->hashsize/2;
> >>>                             break;
> >>> +                   case CRYPTO_AES_128_GMAC:
> >>> +                   case CRYPTO_AES_192_GMAC:
> >>> +                   case CRYPTO_AES_256_GMAC:
> >>> +                           alen = esph->hashsize;
> >>> +                           break;
> >>>                     default:
> >>>                             alen = AH_HMAC_HASHLEN;
> >>>                             break;
> >>
> >> This introduces a LINT compile failure:
> >>
> >> /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared
> identifier
> >> 'CRYPTO_AES_128_GMAC'
> >>                     case CRYPTO_AES_128_GMAC:
> >>                          ^
> >> /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared
> identifier
> >> 'CRYPTO_AES_192_GMAC'
> >>                     case CRYPTO_AES_192_GMAC:
> >>                          ^
> >> /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared
> identifier
> >> 'CRYPTO_AES_256_GMAC'
> >>                     case CRYPTO_AES_256_GMAC:
> >>                          ^
> >> 3 errors generated.
> >> --- xform_esp.o ---
> >>
> >
> > Apologies, fixed in 285347.  BTW The LINT conf in amd64 is ignored.  Why?
>
> What do you mean?
>
>
There was some temporary confusion regarding the LINT conf being
dynamically generated (and thus properly ignored by svn), now resolved.

-Patrick