svn commit: r277653 - head/sys/dev/netmap

[Adrian Chadd]

Eep, I'll make sure I add that to the next commit / MFC.

Thanks,


-adrian


On 24 January 2015 at 11:52, Alfred Perlstein <alfred at freebsd.org> wrote:
> Wasn't this pointed out by James K?
>
>
> On 1/24/15 11:49 AM, Adrian Chadd wrote:
>>
>> Author: adrian
>> Date: Sat Jan 24 19:49:27 2015
>> New Revision: 277653
>> URL: https://svnweb.freebsd.org/changeset/base/277653
>>
>> Log:
>>    Change the permissions from 0660 to 0600.
>>       Otherwise people in wheel can do things with netmap, including
>>    but not limited to promisc transmit/receive.
>>       Approved by:      luigi
>>    MFC after:   1 week
>>
>> Modified:
>>    head/sys/dev/netmap/netmap.c
>>
>> Modified: head/sys/dev/netmap/netmap.c
>>
>> ==============================================================================
>> --- head/sys/dev/netmap/netmap.c        Sat Jan 24 19:13:03 2015
>> (r277652)
>> +++ head/sys/dev/netmap/netmap.c        Sat Jan 24 19:49:27 2015
>> (r277653)
>> @@ -3075,10 +3075,10 @@ netmap_init(void)
>>   #ifdef __FreeBSD__
>>         /* support for the 'eternal' flag */
>>         netmap_dev = make_dev_credf(MAKEDEV_ETERNAL_KLD,
>> -               &netmap_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0660,
>> +               &netmap_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0600,
>>                               "netmap");
>>   #else
>> -       netmap_dev = make_dev(&netmap_cdevsw, 0, UID_ROOT, GID_WHEEL,
>> 0660,
>> +       netmap_dev = make_dev(&netmap_cdevsw, 0, UID_ROOT, GID_WHEEL,
>> 0600,
>>                               "netmap");
>>   #endif
>>         if (!netmap_dev)
>>
>