svn commit: r277643 - in head/sys: arm/arm dev/mem i386/i386 mips/mips sparc64/sparc64

Ian Lepore ian at freebsd.org
Sat Jan 24 15:25:37 UTC 2015


On Sat, 2015-01-24 at 12:51 +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sat Jan 24 12:51:15 2015
> New Revision: 277643
> URL: https://svnweb.freebsd.org/changeset/base/277643
> 
> Log:
>   Remove Giant from /dev/mem and /dev/kmem.  It is definitely not needed
>   for i386, and from the code inspection, nothing in the
>   arm/mips/sparc64 implementations depends on it.
>   

I'm not sure I agree with that.  On arm the memrw() implementation uses
a single statically-allocated page of kva space into which it maps each
physical page in turn in the main loop.  What prevents preemption or
multicore access to /dev/mem from trying to use that single page for
multiple operations at once?

-- Ian




More information about the svn-src-head mailing list