svn commit: r277570 - head/usr.bin/vmstat

Ian Lepore ian at freebsd.org
Fri Jan 23 21:06:01 UTC 2015


On Fri, 2015-01-23 at 13:56 -0700, Will Andrews wrote:
> On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote:
> > What's the rationale behind this change?
> 
> The rationale was to match the clock used to the name (and implied intent)
> of the variables used to store/manipulate the data.
> 
> It's possible that 'uptime' is entirely the wrong term in vmstat, in which
> case the naming used elsewhere in vmstat needs to be changed too.
> 

It seems like there's a good chance this is a step backwards.  In the
old days if you wanted a monotonic clock, uptime was your only option.
Eventually we implemented clock_gettime() and CLOCK_MONOTONIC and likely
someone changed the calls in vmstat but perhaps not related variable
names.  So now we've gone back to the wrong clock to match the old
variable names.  (I don't see anything in the vmstat manpage about
actually displaying or using uptime values at all.)

-- Ian




More information about the svn-src-head mailing list