svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

Warner Losh imp at bsdimp.com
Thu Jan 22 05:21:06 UTC 2015


> On Jan 20, 2015, at 12:35 AM, Hans Petter Selasky <hps at selasky.org> wrote:
> 
> On 01/20/15 06:22, Adrian Chadd wrote:
>> Sweet, thanks. I'l test it, but anything that changes the locking to
>> TCP is going to need a more thorough review. The "there be dragons"
>> disclaimer is appropriate.:)
> 
> No changes in locking - simply some minor code reordering.

This isn’t entirely true. You changed the INFO_WLOCK protocol, and also drop the WLOCK to acquire the INFO_WLOCK in places, and it isn’t clear to me at all why this is safe to do. Please document the analysis you did to show that was safe.

Warner



More information about the svn-src-head mailing list