svn commit: r277421 - head/sys/powerpc/powerpc

Konstantin Belousov kostikbel at gmail.com
Tue Jan 20 19:14:44 UTC 2015


On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote:
> Author: nwhitehorn
> Date: Tue Jan 20 16:21:59 2015
> New Revision: 277421
> URL: https://svnweb.freebsd.org/changeset/base/277421
> 
> Log:
>   There does not seem to be any reason to acquire GIANT here. Follow amd64
>   in removing it.
>   
>   MFC after:	1 month
> 
> Modified:
>   head/sys/powerpc/powerpc/mem.c
> 
> Modified: head/sys/powerpc/powerpc/mem.c
> ==============================================================================
> --- head/sys/powerpc/powerpc/mem.c	Tue Jan 20 15:45:09 2015	(r277420)
> +++ head/sys/powerpc/powerpc/mem.c	Tue Jan 20 16:21:59 2015	(r277421)
> @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio,
>  	cnt = 0;
>  	error = 0;
>  
> -	GIANT_REQUIRED;
> -

This is not an acquisition, to be pedantic.  Really, it is cdevsw which
has D_NEEDGIANT flag which acquires Giant.  After architectures get
rid of GIANT_REQUIRED, flag can be removed.


More information about the svn-src-head mailing list