svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

[Adrian Chadd]

On 19 January 2015 at 20:30, Hans Petter Selasky <hps at selasky.org> wrote:
> On 01/19/15 22:59, Adrian Chadd wrote:
>>
>> Hi,
>>
>> Would you please check what the results of this are with CPU specific
>> callwheels?
>>
>> I'm doing some 10+ gig traffic testing on -HEAD with RSS enabled (on
>> ixgbe) and with this setup, the per-CPU TCP callwheel stuff is
>> enabled. But all the callwheels are now back on clock(0) and so is the
>> lock contention. :(
>>
>> Thanks,
>>
>
> Hi,
>
> Like stated in the manual page, callout_reset_curcpu/on() does not work with
> MPSAFE callouts any more!

Hm!

How many places in the kernel did you leave like this? :P

I mean, I'm glad to have stuff be forced to be cleaned up, but you
didn't even leave a KASSERT or a debug warning that something
unsupported is being done. I'm sure I'm not going to be the first
person to be caught out like this.

> You need to use callout_init_{mtx,rm,rw} and remove the custom locking
> inside the callback in the TCP stack to get it working like before!

Would you please give me a hand with this? I've sunk a lot of (unpaid,
personal) spare time into getting the RSS stuff into shape and now a
lot of it just plainly doesn't do anything. :(



-adrian