svn commit: r277163 - head/sys/dev/cardbus

John Baldwin jhb at FreeBSD.org
Thu Jan 15 18:51:53 UTC 2015


On 1/15/15 11:20 AM, Nathan Whitehorn wrote:
> 
> On 01/14/15 16:07, Warner Losh wrote:
>>> On Jan 14, 2015, at 8:32 AM, Justin Hibbits <chmeeedalf at gmail.com>
>>> wrote:
>>>
>>> On Wed, 14 Jan 2015 09:23:05 -0500
>>> John Baldwin <jhb at FreeBSD.org> wrote:
>>>
>>>> On 1/14/15 12:41 AM, Warner Losh wrote:
>>>>> Author: imp
>>>>> Date: Wed Jan 14 05:41:31 2015
>>>>> New Revision: 277163
>>>>> URL: https://svnweb.freebsd.org/changeset/base/277163
>>>>>
>>>>> Log:
>>>>>   Add a rather obnoxious warning if you don't have NEW_PCIB defined
>>>>>   since it's a total crap shoot if things will work.
>>>> Should we just make it a #error instead?  (Some day I hope to have
>>>> NEW_PCIB enabled by default and remove the old code.  Will take a
>>>> while to get there for the generic PCI code, but cardbus is probably
>>>> only used on x86 so that would be fine.)
>>>>
>>> Also powerpc, but NEW_PCIB is default there as well.
>> PowerPC doesn’t seem to defined the bus number resources.
>>
>> Warner
>>
> 
> Which ones?
> -Nathan

PCI_RES_BUS.

https://svnweb.freebsd.org/base?view=revision&revision=261790

I misspoke about it being in the nexus.  On x86 it is done in the ACPI
Host-PCI bridge drivers (since those have a _SEG method to know which
PCI domain/segment/hose the child bus belongs to).  You could
conceivably do it higher up at whatever level understands which PCI
domain a given Host-PCI bridge lives in.

If you only ever support a single PCI domain, you could just place it in
the nexus with a hardcoded domain arg of 0 to the pci_domain_*() functions.

-- 
John Baldwin


More information about the svn-src-head mailing list