svn commit: r279381 - head/sys/boot/amd64/efi

John Baldwin jhb at freebsd.org
Sat Feb 28 12:41:30 UTC 2015


On Friday, February 27, 2015 10:22:06 PM David E. O'Brien wrote:
> Author: obrien
> Date: Fri Feb 27 22:22:05 2015
> New Revision: 279381
> URL: https://svnweb.freebsd.org/changeset/base/279381
> 
> Log:
>   Use sys/boot/userboot/libstand/ and not /usr/lib/libstand.a.
> 
> Modified:
>   head/sys/boot/amd64/efi/Makefile

Ugh, this is wrong, please revert.  For one, I just ran into a bug where the 
EFI bits are prone to random corruption because the EFI ABI doesn't use a 
redzone like the System V amd64 ABI.  userboot is a C program though and will 
use the System V ABI, so it can't share libstand with loader.efi.  Locally I 
have changed /usr/lib/libstand on amd64 to use -mno-red-zone as loader.efi is 
the only thing on amd64 that uses it (so this avoids mixing the ABIs).

Also, if anything this should be using the lib/libstand from OBJDIR as that is
what other loader binaries do.

-- 
John Baldwin


More information about the svn-src-head mailing list