svn commit: r279028 - in head/usr.sbin: . ifmcstat

Bruce Simpson bms at fastmail.net
Fri Feb 20 03:14:23 UTC 2015


Gleb,

Correct me if I'm wrong -- but doesn't this set of changes remove the 
ability for the user to see the stack-wide membership filters on each 
link? The implementation required KVM as it must inspect the SSM filters 
themselves to obtain this information.

On 19/02/2015 22:42, Gleb Smirnoff wrote:
>    Now that IGMP and MLD sysctls provide a clean API structures that do not
>    leak kernel internal stuff, reconnect ifmcstat(1) back to build.

The change is well motivated, but the job is only half done.

The backend code you have added simply reflects the per-link information 
to userland as a flat data structure; it does not appear to report what 
the membership filters are.

This would require taking a lock, walking the RB-tree for the in-mode 
filters, and serializing the data to userland as a variable length 
structure.

regards
Bruce


More information about the svn-src-head mailing list