svn commit: r278634 - head/lib/libc/gen

[Bjoern A. Zeeb]

> On 12 Feb 2015, at 22:34 , Pedro Giffuni <pfg at FreeBSD.org> wrote:
> 
> 
> On 02/12/15 17:27, Bjoern A. Zeeb wrote:
>>> On 12 Feb 2015, at 21:07 , Pedro F. Giffuni <pfg at FreeBSD.org> wrote:
>>> 
>>> Author: pfg
>>> Date: Thu Feb 12 21:07:42 2015
>>> New Revision: 278634
>>> URL: https://svnweb.freebsd.org/changeset/base/278634
>>> 
>>> Log:
>>>  ulimit(3): Fix broken check.
>>> 
>>>  The existing implementation had a broken comparison that could overflow.
>>>  Replace this with a check that avoids the overflow before it happens.
>>> 
>>>  Consistently return a maximum value also on the case of negative
>>>  arguments since negative is considered an overflow and means
>>>  infinity for our current setrlimit().
>>> 
>>>  Discussed with:	bde (rather extensively)
>>> 
>> Did this compile?
>> 
> 
> Yes! Any log message to share?

Now I do again; had lost them due to buildworld starting over again:

===> lib/libc_nonshared (obj,depend,all,install)
cc1: warnings being treated as errors
/scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c: In function 'ulimit':
/scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c:56: warning: comparison is always false due to limited range of data type
/scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c:57: warning: overflow in implicit constant conversion
--- ulimit.So ---
*** [ulimit.So] Error code 1


mips.mipsn32 buildworld failed, check _.mips.mipsn32.buildworld for details
mips.mips buildworld failed, check _.mips.mips.buildworld for details
powerpc.powerpc buildworld failed, check _.powerpc.powerpc.buildworld for details
mips.mipsel buildworld failed, check _.mips.mipsel.buildworld for details
arm.armeb buildworld failed, check _.arm.armeb.buildworld for details
arm.armv6hf buildworld failed, check _.arm.armv6hf.buildworld for details
arm.arm buildworld failed, check _.arm.arm.buildworld for details
arm.armv6 buildworld failed, check _.arm.armv6.buildworld for details
pc98.i386 buildworld failed, check _.pc98.i386.buildworld for details
i386.i386 buildworld failed, check _.i386.i386.buildworld for details
powerpc.powerpc64 buildworld failed, check _.powerpc.powerpc64.buildworld for details
amd64.amd64 buildworld failed, check _.amd64.amd64.buildworld for details