svn commit: r278525 - head/sys/kern

Rui Paulo rpaulo at FreeBSD.org
Tue Feb 10 18:35:47 UTC 2015


Author: rpaulo
Date: Tue Feb 10 18:35:46 2015
New Revision: 278525
URL: https://svnweb.freebsd.org/changeset/base/278525

Log:
  Remove a printf and an strlen() from the coredump code.

Modified:
  head/sys/kern/kern_sig.c

Modified: head/sys/kern/kern_sig.c
==============================================================================
--- head/sys/kern/kern_sig.c	Tue Feb 10 18:05:58 2015	(r278524)
+++ head/sys/kern/kern_sig.c	Tue Feb 10 18:35:46 2015	(r278525)
@@ -3225,14 +3225,13 @@ out:
 static int
 coredump_sanitise_path(const char *path)
 {
-	size_t len, i;
+	size_t i;
 
 	/*
 	 * Only send a subset of ASCII to devd(8) because it
 	 * might pass these strings to sh -c.
 	 */
-	len = strlen(path);
-	for (i = 0; i < len; i++)
+	for (i = 0; path[i]; i++)
 		if (!(isalpha(path[i]) || isdigit(path[i])) &&
 		    path[i] != '/' && path[i] != '.' &&
 		    path[i] != '-')
@@ -3365,10 +3364,8 @@ close:
 	snprintf(data, sizeof(data), "comm=%s ", fullpath);
 	free(freepath, M_TEMP);
 	freepath = NULL;
-	if (vn_fullpath_global(td, vp, &fullpath, &freepath) != 0) {
-		printf("could not find coredump\n");
+	if (vn_fullpath_global(td, vp, &fullpath, &freepath) != 0)
 		goto out;
-	}
 	if (!coredump_sanitise_path(fullpath))
 		goto out;
 	strlcat(data, "core=", sizeof(data));


More information about the svn-src-head mailing list