svn commit: r278469 - in head/sys: kern sys

hiren panchasara hiren at strugglingcoder.info
Mon Feb 9 20:19:33 UTC 2015


On 02/09/15 at 07:19P, Randall Stewart wrote:
> Author: rrs
> Date: Mon Feb  9 19:19:44 2015
> New Revision: 278469
> URL: https://svnweb.freebsd.org/changeset/base/278469
> 
> Log:
>   This fixes two conditions that can incur when migration
>   is being done in the callout code and harmonizes the macro
>   use.:
>   1) The callout_active() will lie. Basically if a migration
>      is occuring and the callout is about to expire and the
>      migration has been deferred, the callout_active will no
>      longer return true until after the migration. This confuses
>      and breaks callers that are doing callout_init(&c, 1); such
>      as TCP.
>   2) The migration code had a bug in it where when migrating, if
>      a two calls to callout_reset came in and they both collided with
>      the callout on the wheel about to run, then the second call to
>      callout_reset would corrupt the list the callout wheel uses
>      putting the callout thread into a endless loop.
>   3) Per imp, I have fixed all the macro occurance in the code that
>      were for the most part being ignored.
>   
>   Phabricator D1711 and looked at by lstewart and jhb and sbruno.
>   Reviewed by:	kostikbel, imp, adrian, hselasky
>   MFC after:	3 days
>   Sponsored by:	Netflix Inc.

Thanks Randall for the fix.

For future reference, correct way to specify phabric review is:
Differential Revision: https://reviews.freebsd.org/D1711 

This triggers changes to the review on phabricator with reference to this
commit.

Cheers,
Hiren
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20150209/7b4fabf0/attachment.sig>


More information about the svn-src-head mailing list