svn commit: r278467 - head/usr.sbin/bsdconfig/share

[Baptiste Daroussin]

On Mon, Feb 09, 2015 at 07:16:19PM +0000, Devin Teske wrote:
> Author: dteske
> Date: Mon Feb  9 19:16:19 2015
> New Revision: 278467
> URL: https://svnweb.freebsd.org/changeset/base/278467
> 
> Log:
>   Replace the only instance of sed(1) in bsdconfig(8) with awk(1).
>   
>   MFC after:	3 days
> 
> Modified:
>   head/usr.sbin/bsdconfig/share/keymap.subr
> 
> Modified: head/usr.sbin/bsdconfig/share/keymap.subr
> ==============================================================================
> --- head/usr.sbin/bsdconfig/share/keymap.subr	Mon Feb  9 17:53:16 2015	(r278466)
> +++ head/usr.sbin/bsdconfig/share/keymap.subr	Mon Feb  9 19:16:19 2015	(r278467)
> @@ -219,7 +219,7 @@ f_keymap_get_all()
>  			echo -n "$k "
>  			# NOTE: Translate '8x8' to '8x08' before sending to
>  			# sort(1) so that things work out as we might expect.
> -			debug= keymap_$k get desc | sed -e 's/8x8/8x08/g'
> +			debug= keymap_$k get desc | awk 'gsub(/8x8/,"8x08")||1'
>  		done | sort -k2 | awk '{
>  			printf "%s%s", (started ? " " : ""), $1; started = 1
>  		}'

Out of curiosity what is the point of preferring awk over sed? the awk binary
being larger and depending on 2 libraries versus sed only depending on one?

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20150209/eb870362/attachment.sig>