svn commit: r278303 - in head/sys: dev/cxgbe modules/cxgbe modules/cxgbe/if_cxl

[Navdeep Parhar]

On 02/05/15 17:33, NGie Cooper wrote:
> On Thu, Feb 5, 2015 at 5:10 PM, Navdeep Parhar <np at freebsd.org> wrote:
>> Author: np
>> Date: Fri Feb  6 01:10:04 2015
>> New Revision: 278303
>> URL: https://svnweb.freebsd.org/changeset/base/278303
>>
>> Log:
>>    cxgbe(4): Add a minimal if_cxl module that pulls in the real driver as
>>    a dependency.  This ensures "ifconfig cxl<n> ..." does the right thing
>>    even when it's run with no driver loaded.
>>
>>    if_cxl.ko is the tiniest module in /boot/kernel.
>
> A couple things:
>
> 1. cxl(4) doesn't have a manpage:

cxgbe(4) is the man page, cxl(4) should probably link to that.

>
> $ man 4 cxl
> No manual entry for cxl
> $ man 4 if_cxl
> No manual entry for if_cxl
>
> 2. This could have been done with hardlinks to avoid creating an
> additional driver (and on the plus side it saves disk space):

What is the collective wisdom on hard links vs. dummy module?  I'm open 
to either of them.  In this particular case the end is more important 
than the means.

About 4KB worth of disk space is involved.

> ...
>
> This is basically what I'm going to set out and do to fix this PR:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186449 (it's another
> item that irritates me with misnamed drivers, like ixgbe.ko used to
> be...).

It was the bugzilla email to freebsd-net with your grab of 186449 that 
reminded me that I needed to fix "ifconfig cxl" for cxgbe. :-)

> Using hardlinks instead of renaming the driver is preferred because it
> makes MFCing possible without breaking loader.conf for sysadmins. In
> general, major version steps (CURRENT) should use if_<foo>
> consistently.

My change doesn't break any loader.conf.  if_cxgbe_load in loader.conf 
will continue to work exactly as before.  if_cxl_load will never be 
required, but won't do any harm either.

Regards,
Navdeep