svn commit: r278223 - head/lib/clang

[NGie Cooper]

On Wed, Feb 4, 2015 at 1:16 PM, Dimitry Andric <dim at freebsd.org> wrote:
> On 04 Feb 2015, at 22:09, NGie Cooper <yaneurabeya at gmail.com> wrote:
>>
>> On Wed, Feb 4, 2015 at 1:00 PM, Dimitry Andric <dim at freebsd.org> wrote:
>>> Author: dim
>>> Date: Wed Feb  4 21:00:29 2015
>>> New Revision: 278223
>>> URL: https://svnweb.freebsd.org/changeset/base/278223
>>>
>>> Log:
>>>  For now, add -stdlib=libc++ to the flags for building clang, since that
>>>  makes it easier to build head on stable/9, where libstdc++ is still the
>>>  default.  We can revisit this when somebody will try to build base with
>>>  gcc 4.8.1 or higher, and its included libstdc++.
>>
>> Maybe this should be conditionalized on COMPILER_TYPE?
>
> COMPILER_TYPE doesn't say anything about the C++ library used.  Maybe we
> need a CXX_LIBRARY_TYPE setting for it?
>
> That said, you may be right that it should be conditionalized on the
> compiler type anyway, since gcc does not support the -stdlib= option.

    Yeah... true.
    My original point was coming more from a perspective that this was
being done strictly for the GNU toolchain, so conditionalizing the
CFLAGS on the compiler being used seemed reasonable.
Thanks!