svn commit: r292955 - head/lib/libmd

Jonathan T. Looney jtl at freebsd.org
Thu Dec 31 18:45:03 UTC 2015


Dear Bruce,

On 12/30/15, 10:03 PM, "Bruce Evans" <brde at optusnet.com.au> wrote:

>On Wed, 30 Dec 2015, Jonathan T. Looney wrote:
>
>> Log:
>>  Fix a file descriptor leak in mdXhl.c (which is used by numerous
>>hashing
>>  algorithms.
>
>This code had amazingly low quality and is still especially broken near
>the main leak fixed.

Thanks for your attention to our code, and for pointing out these bugs. I
just volunteered to fix the "new" Coverity alert for a file descriptor
leak. (It was a "new" alert due to r292782, which reused this file for
SHA384.) However, I agree that there are still bugs in the code, and I'm
happy to work on those, too.

Happy New Year!

Jonathan




More information about the svn-src-head mailing list