svn commit: r292626 - head/sys/kern

Mateusz Guzik mjguzik at gmail.com
Tue Dec 29 12:04:36 UTC 2015


On Tue, Dec 22, 2015 at 02:29:36PM -0800, NGie Cooper wrote:
> 
> > On Dec 22, 2015, at 13:17, John Baldwin <jhb at freebsd.org> wrote:
> > 
> > On Tuesday, December 22, 2015 09:07:33 PM Garrett Cooper wrote:
> 
>> 
> > It shouldn't be zero, I think == 1 would be best actually.
> 
> I’ll boot up GENERIC and see whether or not it works with == 1.
> Thanks :)!

Any value other than in 1 is a bug. The value of 0 means the destination
is not used, although it clearly is. Since the counter is signed,
sufficiently big amount of users can actually make it negative, although
that's an unrealistic for now.

TL;DR please change it to equality check against 1.

-- 
Mateusz Guzik <mjguzik gmail.com>


More information about the svn-src-head mailing list