svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks

[Kristof Provost]

> On 16 Dec 2015, at 01:56, Randall Stewart <rrs at freebsd.org> wrote:
> 
> Author: rrs
> Date: Wed Dec 16 00:56:45 2015
> New Revision: 292309
> URL: https://svnweb.freebsd.org/changeset/base/292309
> 
> Log:
>  First cut of the modularization of our TCP stack. Still
>  to do is to clean up the timer handling using the async-drain.
>  Other optimizations may be coming to go with this. Whats here
>  will allow differnet tcp implementations (one included).
>  Reviewed by:	jtl, hiren, transports
>  Sponsored by:	Netflix Inc.
>  Differential Revision:	D4055

I suspect this commit broke my machine. I run VIMAGE jails, and see the following panic as soon as the first jails starts:

panic: lock "tcp_func_lock" 0xffffffff81d11dd0 already initialised

#0  doadump (textdump=1) at pcpu.h:221
#1  0xffffffff80a25b55 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:364
#2  0xffffffff80a2612b in vpanic (fmt=<value optimized out>, ap=<value optimized out>) at /usr/src/sys/kern/kern_shutdown.c:757
#3  0xffffffff80a25f66 in kassert_panic (fmt=<value optimized out>) at /usr/src/sys/kern/kern_shutdown.c:647
#4  0xffffffff80a64335 in lock_init (lock=0xffffffff81d11dd0, class=0xffffffff8188eb40, name=0xffffffff813c4f54 "tcp_func_lock", type=0x0, flags=2228224) at /usr/src/sys/kern/subr_lock.c:78
#5  0xffffffff80a231ed in _rw_init_flags (c=0xffffffff81d11de8, name=0xffffffff813c4f54 "tcp_func_lock", opts=<value optimized out>) at /usr/src/sys/kern/kern_rwlock.c:209
#6  0xffffffff80bfa38f in tcp_init () at /usr/src/sys/netinet/tcp_subr.c:598
#7  0xffffffff80aa15e8 in vnet_domain_init (arg=0xffffffff818ac898) at /usr/src/sys/kern/uipc_domain.c:175
#8  0xffffffff80b207d7 in vnet_alloc () at /usr/src/sys/net/vnet.c:575
#9  0xffffffff809f1763 in kern_jail_set (td=0xfffff80011a244d0, optuio=0xfffff800045d0600, flags=1) at /usr/src/sys/kern/kern_jail.c:1353
#10 0xffffffff809f3151 in sys_jail_set (td=0xfffff80011a244d0, uap=0xfffffe0239f02b80) at /usr/src/sys/kern/kern_jail.c:534
#11 0xffffffff80e8911b in amd64_syscall (td=0xfffff80011a244d0, traced=0) at subr_syscall.c:135
#12 0xffffffff80e6908b in Xfast_syscall () at /usr/src/sys/amd64/amd64/exception.S:394
#13 0x0000000800e9f8ca in ?? ()


That was with r292398, but I’ve just tested r292448 and it’s still affected.

Regards,
Kristof