svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks

[Randall Stewart]

Ahh I think I see this is a difference between our friend
clang and gcc.. since I bet ppc uses gcc not clang :-o

I will have something for you in a sec.. sorry about that Ed

R

This is the difference between 
On Dec 16, 2015, at 6:00 AM, Ed Maste <emaste at freebsd.org> wrote:

> On 16 December 2015 at 00:56, Randall Stewart <rrs at freebsd.org> wrote:
>> Author: rrs
>> Date: Wed Dec 16 00:56:45 2015
>> New Revision: 292309
>> URL: https://svnweb.freebsd.org/changeset/base/292309
>> 
>> Log:
>>  First cut of the modularization of our TCP stack. Still
>>  to do is to clean up the timer handling using the async-drain.
>>  Other optimizations may be coming to go with this. Whats here
>>  will allow differnet tcp implementations (one included).
>>  Reviewed by:  jtl, hiren, transports
>>  Sponsored by: Netflix Inc.
>>  Differential Revision:        D4055
> 
> This broke at least powerpc builds:
> 
> /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:148:
> warning: redundant redeclaration of 'tcp_dooptions'
> [-Wredundant-decls]
> /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:736: warning:
> previous declaration of 'tcp_dooptions' was here
> /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:150:
> warning: redundant redeclaration of 'tcp_dropwithreset'
> [-Wredundant-decls]
> /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:738: warning:
> previous declaration of 'tcp_dropwithreset' was here
> /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:152:
> warning: redundant redeclaration of 'tcp_pulloutofband'
> [-Wredundant-decls]
> /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:740: warning:
> previous declaration of 'tcp_pulloutofband' was here
> /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:153:
> warning: redundant redeclaration of 'tcp_xmit_timer'
> [-Wredundant-decls]
> /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:741: warning:
> previous declaration of 'tcp_xmit_timer' was here
> ...

--------
Randall Stewart
rrs at netflix.com
803-317-4952