svn commit: r291994 - head/include

Bruce Evans brde at optusnet.com.au
Thu Dec 10 07:46:18 UTC 2015


On Thu, 10 Dec 2015, Hajimu UMEMOTO wrote:

>>>>>> On Wed, 9 Dec 2015 18:19:16 +1100 (EST)
>>>>>> Bruce Evans <brde at optusnet.com.au> said:
>
> brde> resolv.h already had massinve namespace pollution and style bugs in
> brde> its includes.  One more include of a header that is relatively clean
> brde> since it is tiny and was designed for minimising namespace pollution
> brde> makes little difference.
>
> I understood.  Thank you for your detailed explanation.
> However, I realized that r289315 changed the size of struct
> __res_state.  It broke binary backward compatibility.  I think we
> still need to revert its change in struct __res_state and move them
> into struct __res_state_ext.

I see.

Most of the pollution in resolv.h dates from 1993, so is hard to fix
now.  It was not in 4.4BSD.  In 4.4BSD, <stdio.h> was a prerequisite,
and undocumented APIs like fp_query() that used FILE were named with
leading underscores.  The ABI changes in __res_state are mostly newer
than than 1993.

Bruce


More information about the svn-src-head mailing list