svn commit: r291855 - head/sys/cddl/dev/profile

Andrew Turner andrew at FreeBSD.org
Sat Dec 5 10:00:02 UTC 2015


Author: andrew
Date: Sat Dec  5 10:00:01 2015
New Revision: 291855
URL: https://svnweb.freebsd.org/changeset/base/291855

Log:
  Allow the artificial profile frames to be adjusted as needed by the user.
  While here update for armv6 to a tested value.
  
  Submitted by:	Howard Su <howard0su at gmail.com>
  Reviewed by:	stat
  Differential Revision:	https://reviews.freebsd.org/D4315

Modified:
  head/sys/cddl/dev/profile/profile.c

Modified: head/sys/cddl/dev/profile/profile.c
==============================================================================
--- head/sys/cddl/dev/profile/profile.c	Sat Dec  5 09:53:58 2015	(r291854)
+++ head/sys/cddl/dev/profile/profile.c	Sat Dec  5 10:00:01 2015	(r291855)
@@ -50,6 +50,7 @@
 #include <sys/proc.h>
 #include <sys/selinfo.h>
 #include <sys/smp.h>
+#include <sys/sysctl.h>
 #include <sys/uio.h>
 #include <sys/unistd.h>
 #include <machine/cpu.h>
@@ -134,10 +135,7 @@ struct profile_probe_percpu;
 #endif
 
 #ifdef __arm__
-/*
- * At least on ARMv7, this appears to work quite well.
- */
-#define	PROF_ARTIFICIAL_FRAMES	10
+#define	PROF_ARTIFICIAL_FRAMES	3
 #endif
 
 #ifdef __aarch64__
@@ -233,7 +231,12 @@ static dtrace_pops_t profile_pops = {
 static struct cdev		*profile_cdev;
 static dtrace_provider_id_t	profile_id;
 static hrtime_t			profile_interval_min = NANOSEC / 5000;	/* 5000 hz */
-static int			profile_aframes = 0;			/* override */
+static int			profile_aframes = PROF_ARTIFICIAL_FRAMES;
+
+SYSCTL_DECL(_kern_dtrace);
+SYSCTL_NODE(_kern_dtrace, OID_AUTO, profile, CTLFLAG_RD, 0, "DTrace profile parameters");
+SYSCTL_INT(_kern_dtrace_profile, OID_AUTO, aframes, CTLFLAG_RW, &profile_aframes,
+    0, "Skipped frames for profile provider");
 
 static sbintime_t
 nsec_to_sbt(hrtime_t nsec)
@@ -352,7 +355,7 @@ profile_create(hrtime_t interval, char *
 	prof->prof_kind = kind;
 	prof->prof_id = dtrace_probe_create(profile_id,
 	    NULL, NULL, name,
-	    profile_aframes ? profile_aframes : PROF_ARTIFICIAL_FRAMES, prof);
+	    profile_aframes, prof);
 }
 
 /*ARGSUSED*/


More information about the svn-src-head mailing list