svn commit: r287196 - head/sys/kern

Hans Petter Selasky hps at selasky.org
Fri Aug 28 16:29:45 UTC 2015


On 08/27/15 10:15, Julien Charbon wrote:
> Author: jch
> Date: Thu Aug 27 08:15:32 2015
> New Revision: 287196
> URL: https://svnweb.freebsd.org/changeset/base/287196
>
> Log:
>    In callout_stop(), if a callout is both pending and currently
>    being serviced return 0 (fail) but it is applicable only
>    mpsafe callouts.  Thanks to hselasky for finding this.
>
>    Differential Revision:	https://reviews.freebsd.org/D3078 (Updated)
>    Submitted by:		hselasky
>    Reviewed by:		jch
>

Hi,

I suggest that this special case be made into a new function, named 
callout_drain_async() inspired from projects/hps_head and that r287196 
be backed out, so that callout_stop() works like before. See:

https://reviews.freebsd.org/D3521

And that the following patch be MFC'ed to -current from 
projects/hps_head after D3521.

https://svnweb.freebsd.org/changeset/base/287261

It should close the race in question.

--HPS


More information about the svn-src-head mailing list