svn commit: r287009 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf

Luiz Otavio O Souza loos.br at gmail.com
Sat Aug 22 22:34:53 UTC 2015


On Sat, Aug 22, 2015 at 6:18 AM, Ermal Luçi wrote:
>
>
> On Sat, Aug 22, 2015 at 12:02 AM, Luiz Otavio O Souza
> wrote:
>>
>> Author: loos
>> Date: Fri Aug 21 22:02:22 2015
>> New Revision: 287009
>> URL: https://svnweb.freebsd.org/changeset/base/287009
>>
>> Log:
>>   Add ALTQ(9) support for the CoDel algorithm.
>>
>>   CoDel is a parameterless queue discipline that handles variable
>> bandwidth
>>   and RTT.
>>
>>   It can be used as the single queue discipline on an interface or as a
>> sub
>>   discipline of existing queue disciplines such as PRIQ, CBQ, HFSC, FAIRQ.
>>
>>   Differential Revision:        https://reviews.freebsd.org/D3272
>>   Reviewd by:   rpaulo, gnn (previous version)
>
>
> I thought part of this commit message was taken from me as a reviewer, no?

Sorry Ermal, my bad. As you only commented and not accepted the review
I thought you don't want to be implied with a reviewed by.

[...]

>> Added: head/sys/net/altq/altq_codel.c
>>
>> ==============================================================================
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/sys/net/altq/altq_codel.c      Fri Aug 21 22:02:22 2015
>> (r287009)
>> @@ -0,0 +1,477 @@
>> +/*
>> + * CoDel - The Controlled-Delay Active Queue Management algorithm
>> + *
>> + *  Copyright (C) 2013 Ermal Luci <eri at FreeBSD.org>
>
>
> Can you correct my name?
>

Sure, I'll commit the fix soon (probably on monday) I'm AFK this weekend.

I really appreciate your work on Codel.

Regards,
Luiz


More information about the svn-src-head mailing list