svn commit: r286887 - head/sys/dev/sound/midi
Tai-hwa Liang
avatar at FreeBSD.org
Tue Aug 18 13:16:07 UTC 2015
Author: avatar
Date: Tue Aug 18 13:16:06 2015
New Revision: 286887
URL: https://svnweb.freebsd.org/changeset/base/286887
Log:
Using the error return code documented in the comment.
Though there is no direct midi_uninit() caller amongst existing drivers
at this moment, a quick experiment indicates that EBUSY gives users more
precise error message once drivers start to honour this result. For example,
emu_midi_detach() should check the result of mpu401_uninit() and block
module unloading if there is any MIDI I/O in progress.
MFC after: 2 weeks
Modified:
head/sys/dev/sound/midi/midi.c
Modified: head/sys/dev/sound/midi/midi.c
==============================================================================
--- head/sys/dev/sound/midi/midi.c Tue Aug 18 12:50:46 2015 (r286886)
+++ head/sys/dev/sound/midi/midi.c Tue Aug 18 13:16:06 2015 (r286887)
@@ -403,7 +403,7 @@ midi_uninit(struct snd_midi *m)
{
int err;
- err = ENXIO;
+ err = EBUSY;
mtx_lock(&midistat_lock);
mtx_lock(&m->lock);
if (m->busy) {
More information about the svn-src-head
mailing list