svn commit: r286266 - head/usr.bin/ypmatch

[Marcelo Araujo]

Hi Ed,


2015-08-09 19:51 GMT+08:00 Ed Schouten <ed at nuxi.nl>:

> Hi Marcelo,
>
> 2015-08-04 4:34 GMT+02:00 Marcelo Araujo <araujo at freebsd.org>:
> >   Sync the code with the OpenBSD version.
>
> That's a shame. It looks like improvements that we made to our version
> have been undone because of this.
>
>
> > -static void
> > +void
> >  usage(void)
>
> This function could be static.
>
> > +       fprintf(stderr,
> > +           "where\n"
> > +           "\tmapname may be either a mapname or a nickname for a
> map.\n"
> > +           "\t-k prints keys as well as values.\n"
> > +           "\t-t inhibits map nickname translation.\n"
> > +           "\t-x dumps the map nickname translation table.\n");
>
> It is fairly uncommon for BSD utilities to have an extensive help
> output. Man pages are intended for that purpose.
>
> > -       while ((c = getopt(argc, argv, "xd:kt")) != -1)
> > +       while ((c=getopt(argc, argv, "xd:kt")) != -1)
> >                 switch (c) {
> >                 case 'x':
> > -                       for (i = 0; i<sizeof ypaliases/sizeof
> ypaliases[0]; i++)
> > +                       for (i=0; i<sizeof ypaliases/sizeof
> ypaliases[0]; i++)
> > ...
> > -       if ((argc-optind) < 2)
> > +       if ((argc-optind) < 2 )
> > ...
> > -       if (!domainname)
> > +       if (!domainname) {
> >                 yp_get_default_domain(&domainname);
> > +       }
>
> Though the style(9) conformance of tool wasn't ideal, this change made it
> worse.


Agree with you!

These tools are original from OpenBSD, I'm trying first to sync the code
and then will rework them. I will try to send it back to upstream(OpenBSD)
as soon as I have time.

Some of the issues you pointed out were partially fixed at: r286394 and
r286403. It doesn't include the extensive help. bde@ also pointed out it
too me.

I will change my approach for the next updates on yp tools, instead only to
sync it with OpenBSD I will apply our style(9) changes.

Thanks for the review, I will include you on the next ones if you don't
mind.


All the best.
-- 

-- 
Marcelo Araujo            (__)araujo at FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>   \/  \ ^
Power To Server.         .\. /_)