svn commit: r286234 - head/sys/boot/common

[NGie Cooper]

On Mon, Aug 3, 2015 at 10:54 AM, Andriy Gapon <avg at freebsd.org> wrote:
> On 03/08/2015 19:27, Edward Tomasz Napierala wrote:
>> Author: trasz
>> Date: Mon Aug  3 16:27:36 2015
>> New Revision: 286234
>> URL: https://svnweb.freebsd.org/changeset/base/286234
>>
>> Log:
>>   Fix a problem which made loader(8) load non-kld files twice.
>
> What was the problem?
> The change looks like defensive coding, but it's not clear why the loader would
> attempt to load the same file more than once in the first place.
>
>>   For example, without this patch, the following three lines
>>   in /boot/loader.conf would result in /boot/root.img being preloaded
>>   twice, and two md(4) devices - md0 and md1 - being created.

Repro was something like this IIRC:

- Start module load.
- Hit a key to interrupt the boot so it drops into the loader prompt.
- Hit boot again.