svn commit: r286102 - head/usr.bin/wall

Bruce Evans brde at optusnet.com.au
Sat Aug 1 06:40:43 UTC 2015


On Fri, 31 Jul 2015, Pedro Giffuni wrote:

> On 07/31/15 02:12, Bruce Evans wrote:
>> On Fri, 31 Jul 2015, Pedro F. Giffuni wrote:
>>
> ...
>
>>>     static char errbuf[1024];
>>
>> Another static buffer.  The function is obviously not reentrant.  This
>> large static buffer mainly wastes space all the time instead of only
>> when the function is called.
>
> But if I drop that static I get a bunch of errors:

Yes.  I forgot that it is is returned.  Older not so good APIs often
return a pointer to static data.

Bruce


More information about the svn-src-head mailing list