svn commit: r281198 - in head/sys/netgraph/bluetooth: hci include l2cap socket

[Michael Tuexen]

> On 07 Apr 2015, at 13:36, Bjoern A. Zeeb <bz at FreeBSD.org> wrote:
> 
> 
>> On 07 Apr 2015, at 10:22 , Takanori Watanabe <takawata at FreeBSD.org> wrote:
>> 
>> Author: takawata
>> Date: Tue Apr  7 10:22:56 2015
>> New Revision: 281198
>> URL: https://svnweb.freebsd.org/changeset/base/281198
>> 
>> Log:
>> Initial Bluetooth LE support.
>> 
>> Note that sockaddr_l2cap structure is changed , check socket address
>> to initialize new structure member and define L2CAP_SOCKET_CHECKED
>> before including ng_btsocket.h
>> 
>> Differential Revision:        https://reviews.freebsd.org/D2021
>> Reviewed by:emax
>> 
> 
> 
> I see a lot of:
> 
> /scratch/tmp/bz/head.svn/lib/libbluetooth/../../sys/netgraph/bluetooth/include/ng_btsocket.h:246:2: error: #warning "Make sure new member of socket address initialized"
I also do see at least two instances of it breaking the compilation:

--- all_subdir_libbluetooth ---
--- bluetooth.So ---
In file included from /usr/home/tuexen/head/lib/libbluetooth/bluetooth.c:34:
In file included from /usr/home/tuexen/head/lib/libbluetooth/bluetooth.h:49:
/usr/home/tuexen/head/lib/libbluetooth/../../sys/netgraph/bluetooth/include/ng_btsocket.h:246:2: error: "Make sure new member of socket address initialized" [-Werror,-W#warnings]
#warning "Make sure new member of socket address initialized"
 ^
1 error generated.
--- dev.So ---
In file included from /usr/home/tuexen/head/lib/libbluetooth/dev.c:33:
In file included from /usr/home/tuexen/head/lib/libbluetooth/bluetooth.h:49:
/usr/home/tuexen/head/lib/libbluetooth/../../sys/netgraph/bluetooth/include/ng_btsocket.h:246:2: error: "Make sure new member of socket address initialized" [-Werror,-W#warnings]
#warning "Make sure new member of socket address initialized"
 ^
1 error generated.
--- bluetooth.So ---
*** [bluetooth.So] Error code 1

make[5]: stopped in /usr/home/tuexen/head/lib/libbluetooth

Best regards
Michael
> 
> when trying to build kernels.  Is this expected?
> 
> 
>> Modified:
>> head/sys/netgraph/bluetooth/hci/ng_hci_cmds.c
>> head/sys/netgraph/bluetooth/hci/ng_hci_evnt.c
>> head/sys/netgraph/bluetooth/hci/ng_hci_main.c
>> head/sys/netgraph/bluetooth/hci/ng_hci_misc.c
>> head/sys/netgraph/bluetooth/hci/ng_hci_misc.h
>> head/sys/netgraph/bluetooth/hci/ng_hci_ulpi.c
>> head/sys/netgraph/bluetooth/hci/ng_hci_var.h
>> head/sys/netgraph/bluetooth/include/ng_btsocket.h
>> head/sys/netgraph/bluetooth/include/ng_btsocket_l2cap.h
>> head/sys/netgraph/bluetooth/include/ng_hci.h
>> head/sys/netgraph/bluetooth/include/ng_l2cap.h
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_cmds.c
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_cmds.h
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_evnt.c
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_llpi.c
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_llpi.h
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.c
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.h
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_ulpi.c
>> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_var.h
>> head/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c
>> head/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c
>> head/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c
> 
> — 
> Bjoern A. Zeeb                                  Charles Haddon Spurgeon:
> "Friendship is one of the sweetest joys of life.  Many might have failed
> beneath the bitterness of their trial  had they not found a friend."
> 
> 
>