svn commit: r280955 - in head/sys: modules/notrandom dev/notrandom

[Gleb Smirnoff]

  Mateusz,

On Wed, Apr 01, 2015 at 02:02:29PM +0200, Mateusz Guzik wrote:
M> > You can add the seven_region variable to dev/null/null.c and implement
M> > the new device here. Now notrandom.c shares > 50% of code with null.c.
M> 
M> Yeah I know, in fact I got most of the code from that driver.
M> 
M> I just wanted to have a file with my own copyright in the tree, what's
M> so bad about it.
M> 
M> If you feel strongly about it feel free to move it, but I would prefer
M> if you did not.

You are increasing size of kernel object file merely for a selfish reason.

While some systems do not care about kernel object size, some embedded do.
Size of source code also matters. You added new code in FreeBSD, that
is likely to be supported for a long time. Of course maintaing two files,
where one is paste of other, requires more efforts than maintaining
single file.

Mateusz, if you keep the momentum, in the next years we will see lots
of files with your copyright. :) There is no reason to create one
just for this. Also, you can legitimately add your name into header of
null.c if you move code of notrandom there.

-- 
Totus tuus, Glebius.