svn commit: r272281 - head/lib/libpam/modules/pam_login_access

[Dimitry Andric]

On 29 Sep 2014, at 12:36, Bjoern A. Zeeb <bz at FreeBSD.org> wrote:
> Author: bz
> Date: Mon Sep 29 10:36:14 2014
> New Revision: 272281
> URL: http://svnweb.freebsd.org/changeset/base/272281
> 
> Log:
>  Hopefully fix build breakage with gcc passing void * instead of char *
>  to "%s" format string after r272280.
> 
>  PR:		83099 193927
>  MFC after:	3 days
>  X-MFC with:	r272280
> 
> Modified:
>  head/lib/libpam/modules/pam_login_access/pam_login_access.c
> 
> Modified: head/lib/libpam/modules/pam_login_access/pam_login_access.c
> ==============================================================================
> --- head/lib/libpam/modules/pam_login_access/pam_login_access.c	Mon Sep 29 08:57:36 2014	(r272280)
> +++ head/lib/libpam/modules/pam_login_access/pam_login_access.c	Mon Sep 29 10:36:14 2014	(r272281)
> @@ -94,7 +94,8 @@ pam_sm_acct_mgmt(pam_handle_t *pamh, int
>  		PAM_VERBOSE_ERROR("%s is not allowed to log in on %s",
>  		    user, tty);
>  	} else {
> -		PAM_LOG("Checking login.access for user %s", user);
> +		PAM_LOG("Checking login.access for user %s",
> +		    (const char *)user);
>  		if (login_access(user, "***unknown***") != 0)
>  			return (PAM_SUCCESS);
>  		PAM_VERBOSE_ERROR("%s is not allowed to log in", user);
> 

Just a few lines after the one you fixed it accesses the same variable
again.  Why doesn't it warn there?  And why is 'user' not a char * to
begin with? :)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20140929/45c20889/attachment.sig>