svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Steven Hartland]

----- Original Message ----- 
From: "Will Andrews" <will at firepipe.net>
To: "John Baldwin" <jhb at freebsd.org>
Cc: "Steven Hartland" <killing at multiplay.co.uk>; "src-committers at FreeBSD.org" <src-committers at freebsd.org>; 
<svn-src-all at freebsd.org>; <svn-src-head at freebsd.org>
Sent: Friday, September 19, 2014 6:35 PM
Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs


>I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this
> particular implementation of the tunable, so there is a regression
> that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no
> matter what's in loader.conf).  I believe it's limited to this
> particular tunable, however, because I tested another SYSCTL_PROC that
> had CTLFLAG_TUN set and it worked.

Given I pointed you in this direction I kinda felt guilty that you where having issues
so had a dig.

It took quite a few printf's and a reboots but I found the cause.

The name of your sysctl is conflicting with the 4th loader which believes
your vfs.zfs.debug_flags is a module _flags setting as it matches the reserved
suffix *_flags as detailed in loader.conf (5).

I think the loader should only consider [a-z0-9_]+_flags as module flags as I can't see
any modules having any other chars expecially not "." in their name; but I've no idea
how to do that in 4th.

So the fix is to rename you sysctl e.g. vfs.zfs.debugflags.

Hope this helps.

    Regards
    Steve