svn commit: r271538 - head/sys/net

Gleb Smirnoff glebius at FreeBSD.org
Mon Sep 15 10:56:57 UTC 2014


On Sat, Sep 13, 2014 at 06:13:08PM +0000, Alexander V. Chernikov wrote:
A> @@ -1099,15 +1117,39 @@ vlan_transmit(struct ifnet *ifp, struct 
A>  	 * Send it, precisely as ether_output() would have.
A>  	 */
A>  	error = (p->if_transmit)(p, m);
A> -	if (!error) {
A> -		ifp->if_opackets++;
A> -		ifp->if_omcasts += mcast;
A> -		ifp->if_obytes += len;
A> +	if (error == 0) {
A> +		counter_u64_add(ifv->ifv_opackets, 1);
A> +		counter_u64_add(ifv->ifv_obytes, len);
A> +		counter_u64_add(ifv->ifv_omcasts, 1);
A>  	} else
A>  		ifp->if_oerrors++;
A>  	return (error);
A>  }

This looks like counting all packets as multicasts. Strange that compiler
didn't warn you about write only variable.

P.S. Why did you decide to keep if_oerrors old style?

-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list