svn commit: r269603 - in head: etc/mtree lib/libnv lib/libnv/tests tools/regression/lib/libnv

[yaneurabeya at gmail.com]

On Sep 7, 2014, at 11:57, Antoine Brodin <antoine at freebsd.org> wrote:

> On Tue, Aug 5, 2014 at 8:41 PM, Garrett Cooper <ngie at freebsd.org> wrote:
>> Author: ngie
>> Date: Tue Aug  5 18:41:27 2014
>> New Revision: 269603
>> URL: http://svnweb.freebsd.org/changeset/base/269603
>> 
>> Log:
>>  Integrate lib/libnv into the build/kyua
>> 
>>  Rename all of the TAP test applications from <test> to <test>_test
>>  to match the convention described in the TestSuite wiki page
>> 
>>  Phabric: D538
>>  Approved by: jmmv (mentor)
>>  Sponsored by: EMC / Isilon Storage Division
>> 
>> Added:
>>  head/lib/libnv/tests/
>>  head/lib/libnv/tests/Makefile   (contents, props changed)
>>  head/lib/libnv/tests/nvlist_add_test.c
>>     - copied unchanged from r269562, head/tools/regression/lib/libnv/nvlist_add.c
>>  head/lib/libnv/tests/nvlist_exists_test.c
>>     - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_exists.c
>>  head/lib/libnv/tests/nvlist_free_test.c
>>     - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_free.c
>>  head/lib/libnv/tests/nvlist_get_test.c
>>     - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_get.c
>>  head/lib/libnv/tests/nvlist_move_test.c
>>     - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_move.c
>>  head/lib/libnv/tests/nvlist_send_recv_test.c
>>     - copied unchanged from r269545, head/tools/regression/lib/libnv/nvlist_send_recv.c
>> Deleted:
>>  head/tools/regression/lib/libnv/
>> Modified:
>>  head/etc/mtree/BSD.tests.dist
>>  head/lib/libnv/Makefile
> 
> Hi,
> 
> It seems that after this commit libnv moved from /lib to /usr/lib.

You’re right. SHLIBDIR is being overridden from bsd.own.mk. This patch will fix it:

$ git diff 
diff --git a/lib/libnv/Makefile b/lib/libnv/Makefile
index cad1ea4..4a7c76a 100644
--- a/lib/libnv/Makefile
+++ b/lib/libnv/Makefile
@@ -1,9 +1,10 @@
 # $FreeBSD$
 
+SHLIBDIR?= /lib
+
 .include <src.opts.mk>
 
 LIB=   nv
-SHLIBDIR?= /lib
 SHLIB_MAJOR= 0
 
 SRCS=  dnvlist.c
$ make -VSHLIBDIR
/lib

I’ll put it out for review soon.

Thanks :)!
-Garrett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20140907/9e857516/attachment.sig>