svn commit: r270759 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs vm

[John Baldwin]

On Saturday, August 30, 2014 1:37:43 pm Peter Wemm wrote:
> On Saturday 30 August 2014 02:03:42 Steven Hartland wrote:
> I'm very disappointed in the attention to detail and errors in the commit.  
> I'm almost at the point where I want to ask for the whole thing to be backed 
> out.

I would not be too supportive of that.  This PR has been open for a long, long 
time with many users using patches from it in production loads that were 
greatly improved by the changes and clamoring on the lists multiple times to 
get someone to look at it.  avg@ contributed quite a bit of time to diagnose 
this with Karl early on, but other developers aside from Steven did not.  It 
also was not hard to explain to Karl the meaning of 'cache + free' in the bug 
follow-ups itself (though I believe avg@ had tried this before and it didn't 
sink in that time for some reason).

I know Steven has since committed a fix, but if there are still concerns, I 
think it would be best to not just revert this entirely but to spend some time  
fixing the remaining issues.  Clearly this issue affects a lot of users and 
the earlier fixes to pagedaemon were not sufficient to fix their issues alone.

-- 
John Baldwin