svn commit: r272386 - in head: sbin/ifconfig share/man/man4 sys/net

[Lawrence Stewart]

On 10/27/14 13:43, Lawrence Stewart wrote:
> Hi Hiroki-san,
> 
> On 10/02/14 07:37, Hiroki Sato wrote:
>> Author: hrs
>> Date: Wed Oct  1 21:37:32 2014
>> New Revision: 272386
>> URL: https://svnweb.freebsd.org/changeset/base/272386
>>
>> Log:
>>   Virtualize lagg(4) cloner.  This change fixes a panic when tearing down
>>   if_lagg(4) interfaces which were cloned in a vnet jail.
>>   
>>   Sysctl nodes which are dynamically generated for each cloned interface
>>   (net.link.lagg.N.*) have been removed, and use_flowid and flowid_shift
>>   ifconfig(8) parameters have been added instead.  Flags and per-interface
>>   statistics counters are displayed in "ifconfig -v".
>>   
>>   CR:	D842
>>
>> Modified:
>>   head/sbin/ifconfig/ifconfig.8
>>   head/sbin/ifconfig/iflagg.c
>>   head/share/man/man4/lagg.4
>>   head/sys/net/ieee8023ad_lacp.c
>>   head/sys/net/if_lagg.c
>>   head/sys/net/if_lagg.h
> 
> What was the reasoning for removing the net.link.lagg.* sysctls? We use
> them at Netflix and the new way of obtaining the information via
> ifconfig -v is less structured and significantly higher overhead by
> comparison. Would be good to have the sysctls back or an equivalent low
> overhead way of obtaining the previously available information.

So it turns out I was missing some important context on this matter. We
don't in fact want or need the sysctls back and have a sane way to
access the information via means other than parsing ifconfig output.

In short, apologies for the noise and move along, there's nothing to see
here :)

Cheers,
Lawrence