svn commit: r273734 - head/bin/dd
Bruce Evans
brde at optusnet.com.au
Mon Oct 27 17:08:24 UTC 2014
On Mon, 27 Oct 2014, Kurt Jaeger wrote:
>>> Log:
>>> bin/dd: Fix incorrect casting of arguments
> [...]
>> Both of these work correctly in my version (with a relatively small patch
>> and no breakage of other cases). (I actually typed large values as -1
>> and 11111111111111111111111111. -1 means (uintmax_t)-1 although this
>> is undocumented and now broken).
>
> So, given this detailed review, should I revert the change ?
Yes. You would have to change half of it just to get it to compile
on 32-bit arches.
Bruce
More information about the svn-src-head
mailing list