svn commit: r273446 - head/sys/x86/isa

John Baldwin jhb at freebsd.org
Thu Oct 23 18:38:22 UTC 2014


On Tuesday, October 21, 2014 9:37:33 pm Marcel Moolenaar wrote:
> Author: marcel
> Date: Wed Oct 22 01:37:32 2014
> New Revision: 273446
> URL: https://svnweb.freebsd.org/changeset/base/273446
> 
> Log:
>   Virtual machines can easily have more than 16 option ROMs and
>   when that happens, we happily access our resource array out of
>   bounds. Make sure we stay within the MAX_ROMS limit.
>   While here, bump MAX_ROMS from 16 to 32 to minimize the chance
>   of leaving option ROMs unaccounted for.
>   
>   Obtained from:	Juniper Networks, Inc.

The res[] array should just go away entirely.  This driver never gets 
detached, so its detach routine can get removed.  sc->rnum can become
a local variable in attach, the arrays can be axed, and the entire softc
should be empty.

-- 
John Baldwin


More information about the svn-src-head mailing list