svn commit: r273266 - in head: lib/libkvm sys/compat/freebsd32 sys/kern sys/sys

[Adrian Chadd]

On 18 October 2014 20:20, Luigi Rizzo <rizzo at iet.unipi.it> wrote:
> On Sat, Oct 18, 2014 at 07:36:12PM +0000, Adrian Chadd wrote:
>> Author: adrian
>> Date: Sat Oct 18 19:36:11 2014
>> New Revision: 273266
>> URL: https://svnweb.freebsd.org/changeset/base/273266
>>
>> Log:
>>   Update the ULE scheduler + thread and kinfo structs to use int for cpuid
>>   rather than u_char.
>>
>>   To try and play nice with the ABI, the u_char CPU ID values are clamped
>>   at 254.  The new fields now contain the full CPU ID, or -1 for no cpu.
>
> This causes the following error with gcc:
>
> cc1: warnings being treated as errors
> /usr/home/luigi/FreeBSD/head/sys/kern/kern_intr.c: In function 'intr_setaffinity':
> /usr/home/luigi/FreeBSD/head/sys/kern/kern_intr.c:378: warning: comparison is always true due to limited range of data type
> *** Error code 1
>
> I suppose we can use NOCPU_OLD, or cast.

Hah, good catch! No, we need to convert that use of u_char to int.

I'll do it when I get home.

Thanks!


-a